Add keybinding for snippet menu #1606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
requested review from
SeeminglyScience,
rjmholt and
rkeithhill
SeeminglyScience
approved these changes
Nov 13, 2018
Collaborator
SeeminglyScience
left a comment
SeeminglyScience
left a comment
There was a problem hiding this comment.
I don't have an issue with this one in particular but we should be cautious about adding too many key binds to default VSCode commands. If someone isn't coming from the ISE, then a language extension adding this key bind would likely not be desired.
We really need a welcome/first run experience that asks if they want to enable something like "ISE Compatibility Settings". Side note, that'd probably also be a good place to ask if they want strict PSSA defaults.
Contributor
|
@SeeminglyScience That first-run experience is a great idea! |
Member
Author
|
I like that idea. It would be nice to have something similar to how gitlens has their first-run experience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ISE had a keybinding (Ctrl+J) that would open up a list of all the snippets you have available.
This adds a keybinding for the same thing in VSCode.
Unfortunately, Ctrl+J wasn't available... it's set to "Toggle Pane". So a similar keybinding was added:
Ctrl+Alt+J on Windows & linux
Cmd+Alt+J on macOS