add build.ps1 to align with PSES and other PowerShell projects #1199
Conversation
| if($Test) { | ||
| Invoke-Build Test | ||
| } | ||
| } |
| @@ -0,0 +1,121 @@ | |||
| #!/usr/bin/env pwsh | |||
There was a problem hiding this comment.
added. Wasn't sure which should be on top. Let me know if I have it wrong.
There was a problem hiding this comment.
My testing indicates that the shebang has to be on the first line of the script.
There was a problem hiding this comment.
Yes, shebang must be first line. This would be the exception to the copyright header rule being first.
| @@ -0,0 +1,121 @@ | |||
| #!/usr/bin/env pwsh | |||
There was a problem hiding this comment.
Yes, shebang must be first line. This would be the exception to the copyright header rule being first.
build.ps1
Outdated
| InvokeBuild = "InvokeBuild latest" | ||
| } | ||
|
|
||
| if ((-not $PSVersionTable["OS"]) -or $PSVersionTable["OS"].Contains("Windows")) { |
There was a problem hiding this comment.
Can we just rely on $IsWindows? If it's $null, then we can assume it's Windows since that would be returned by Windows PowerShell. Same for $IsLinux and $IsMacOS.
There was a problem hiding this comment.
Just realized OS isn't used in this script.
build.ps1
Outdated
| param( | ||
| [Parameter()] | ||
| [switch] | ||
| $Bootstrap, |
There was a problem hiding this comment.
Looking at your logic below on lines 101-124, it seems that -Bootstrap should be it's own ParameterSet as it's mutually exclusive to -Clean and -Test?
|
@tylerl0706 I think something went wrong with a push or something. Shouldn't there only be 1 file changed in this PR? |
|
😮 |
TylerLeonhardt
force-pushed
the
add-buildps1
branch
from
8d414a4 to
e36b794
Compare
Resolves: #1127
Here's the build.ps1 PR for PowerShellEditorServices:
PowerShell/PowerShellEditorServices#623
In scope:
build.ps1checks for missing tools and runsInvoke-Build Buildbuild.ps1 -Cleanchecks for missing tools and runsInvoke-Build Cleanand thenInvoke-Build Buildbuild.ps1 -Testchecks for missing tools and runsInvoke-Build Buildand thenInvoke-Build Testbuild.ps1 -Bootstrapinforms you of what tools you are missing