Various fixes for 64-bit VS Code #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the path used for PowerShell on Windows due to the fact that 64-bit VS Code has been released (and is now being promoted as the primary build). We're only pointing to the System32 path for now because VS Code doesn't provide a way to specify a different path in the 32-bit build.
This change enables Mocha-based unit tests for the PowerShell extension using VS Code's embedded test running mode.
This change introduces a new module that contains all the logic for determining the current OS platform, process architecture and OS architecture for use in determining available Windows PowerShell EXE paths. This module helps resolve problems that were introduced by the new 64-bit distribution of Visual Studio Code. Fixes PowerShell#1008 Fixes PowerShell#1007 Fixes PowerShell#1006 Fixes PowerShell#993
This change fixes PowerShell#1020 which states that PowerShell session commands should activate the extension if it isn't already started. These commands are useful for activating a PowerShell session if the user doesn't currently have a PowerShell file open.
|
Argh, AppVeyor doesn't kick in when PR'ing to a non-master branch. At any rate, the plan here is to ship 1.4.2 out of the |
|
Did you add anything to the log file that indicates the architecture of the VSCode instance? Would be handy to know when tracking down bugs. |
|
Nope, good idea! I'll add that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also introduced unit testing for the extension!