Skip to content

Conversation

@TylerLeonhardt
Copy link
Member

🎉

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update:
PowerShellEditorServices.Common.props
module/PowerShellEditorServices/PowerShellEditorServices.psd1
AppVeyor.yml

@TylerLeonhardt
Copy link
Member Author

@rkeithhill yeah those are updated already - maybe you drilled into a particular commit diff?

@rkeithhill
Copy link
Contributor

rkeithhill commented Jul 26, 2018

Yup, the previous release - https://github.com/PowerShell/PowerShellEditorServices/pull/702/files Oh, wait a tic, I see what you're saying and yes, I must have clicked on a particular commit in one of the email messages I got.

@TylerLeonhardt
Copy link
Member Author

Yeah those are all updated in this PR already :)

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TylerLeonhardt TylerLeonhardt merged commit bd400a8 into PowerShell:master Jul 26, 2018
@TylerLeonhardt TylerLeonhardt deleted the prep-for-1.8.2 branch July 26, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants