Fix error w/Start-EditorServices transcript logging using temp console #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error happens because when log level is set to Diagnostic, we use Start-Transcript to log the output of Start-EditorServices.ps1. But the log filename we we're using was always Start-EditorServices.log. When we start a temp console debug session, is using the Start-EditorServices.ps1 script to start the debug session. That attempts to log to the original log file which is locked. This causes an error. The fix is to append the log filename which will be unique per launch of the Start-ES script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error happens because when log level is set to Diagnostic, we use
Start-Transcript to log the output of Start-EditorServices.ps1.
But the log filename we we're using was always Start-EditorServices.log.
When we start a temp console debug session, it's using the
Start-EditorServices.ps1 script to start the debug session.
That attempts to log to the original log file which is locked.
This causes an error. The fix is to append the log filename
which will be unique per launch of the Start-ES script.