Found GetStringForPSCommand - moved parameter dump code into it #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I missed this earlier this week, looks great! |
|
No problem. Everybody's busy. I've been real busy with Keith Dahlby getting a 1.0.0-beta1 version of posh-git out to coincide with the PS Core 6 GA release yesterday. Still have a bit of work to do on the README for that project. |
SeeminglyScience
pushed a commit
to SeeminglyScience/PowerShellEditorServices
that referenced
this pull request
Feb 1, 2018
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
Update ISSUE_TEMPLATE.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I had looked for an existing impl of this but somehow missed
GetStringForPSCommand(). Modified it to render parameter info and use it fromExecuteCommandmethod.Actually, you'd think this ability to render the complete command to a string would be built into the PSCommand type - oh well.