Use new strategy for ConsoleReadLine.ReadKeyAsync to fix macOS and Linux issues #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
changed the title
daviwil
changed the title
…nux issues This change uses a new strategy for providing a quasi-async Console.ReadKey implementation so that key handling works better on Linux and macOS. This should eliminate issues where keys and escape sequences were being echoed incorrectly. It should also eliminate the issue where the backspace key is unusable on these platforms. Resolves PowerShell/vscode-powershell#533. Resolves PowerShell/vscode-powershell#542.
daviwil
force-pushed
the
improved-readline
branch
from
1f415b9 to
8c1a086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses a new strategy for providing a quasi-async
Console.ReadKey implementation so that key handling works better on Linux
and macOS. This should eliminate issues where keys and escape sequences
were being echoed incorrectly. It should also eliminate the issue where
the backspace key is unusable on these platforms.
Resolves PowerShell/vscode-powershell#533.
Resolves PowerShell/vscode-powershell#542.