Skip to content

Fix declaration detection for variables with type constraints #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

Fix declaration detection for variables with type constraints #2006

merged 1 commit into from
Mar 9, 2023

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan requested a review from a team March 9, 2023 00:33
SeeminglyScience
SeeminglyScience requested changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change to check for parameters as well (unless you already have this and I missed it)

@SeeminglyScience SeeminglyScience self-requested a review March 9, 2023 17:54
SeeminglyScience
SeeminglyScience approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm the suggestion, it works! LGTM!

@andyleejordan andyleejordan merged commit 98a97c2 into main Mar 9, 2023
@andyleejordan andyleejordan deleted the andschwa/constrained-types branch March 9, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Area-Symbols and References Issue-Bug A bug to squash.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Go To Definition' does not work when the variable is defined with type hint
2 participants
@andyleejordan @SeeminglyScience