Skip to content

Only run Windows PowerShell 5.1 tests on CI with powershell.exe #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2022
Merged

Only run Windows PowerShell 5.1 tests on CI with powershell.exe #1881

merged 1 commit into from
Aug 12, 2022

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Aug 11, 2022 •
edited
Loading

And only PowerShell Core on CI with pwsh.exe, and re-enable the PowerShell 7.0 tests (oops).

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Test labels Aug 11, 2022
@andyleejordan andyleejordan force-pushed the andschwa/isolate-winps-tests branch from 756e63f to b90afaa Compare August 11, 2022 23:36
@andyleejordan andyleejordan marked this pull request as ready for review August 11, 2022 23:51
@andyleejordan andyleejordan requested a review from a team August 11, 2022 23:51
@andyleejordan andyleejordan added the Ignore Exclude from the changelog. label Aug 12, 2022
SeeminglyScience
SeeminglyScience approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit 8477600 into main Aug 12, 2022
@andyleejordan andyleejordan deleted the andschwa/isolate-winps-tests branch August 12, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Area-Test Ignore Exclude from the changelog. Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyleejordan @SeeminglyScience