Skip to content

Allow multiple code actions if there is more than one SuggestedCorrection of a diagnostic record returned by PSSA #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Allow multiple code actions if there is more than one SuggestedCorrection of a diagnostic record returned by PSSA #1713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a13202c
Return a code action for each diagnostic record returned by PSSA
bergmeister Feb 16, 2022
87e37db
formatting
bergmeister Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions src/PowerShellEditorServices/Services/TextDocument/Handlers/CodeActionHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,24 +81,27 @@ public override async Task<CommandOrCodeActionContainer> Handle(CodeActionParams
string diagnosticId = AnalysisService.GetUniqueIdFromDiagnostic(diagnostic);
if (corrections.TryGetValue(diagnosticId, out MarkerCorrection correction))
{
codeActions.Add(new CodeAction
foreach (ScriptRegion edit in correction.Edits)
{
Title = correction.Name,
Kind = CodeActionKind.QuickFix,
Edit = new WorkspaceEdit
codeActions.Add(new CodeAction
{
DocumentChanges = new Container<WorkspaceEditDocumentChange>(
new WorkspaceEditDocumentChange(
new TextDocumentEdit
{
TextDocument = new OptionalVersionedTextDocumentIdentifier
Title = correction.Name,
Kind = CodeActionKind.QuickFix,
Edit = new WorkspaceEdit
{
DocumentChanges = new Container<WorkspaceEditDocumentChange>(
new WorkspaceEditDocumentChange(
new TextDocumentEdit
{
Uri = request.TextDocument.Uri
},
Edits = new TextEditContainer(correction.Edits.Select(ScriptRegion.ToTextEdit))
}))
}
});
TextDocument = new OptionalVersionedTextDocumentIdentifier
{
Uri = request.TextDocument.Uri
},
Edits = new TextEditContainer(ScriptRegion.ToTextEdit(edit))
}))
}
});
}
}
}

Expand Down