Skip to content

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Jan 19, 2022

Not entirely sure why this can be the case, but a stacktrace from a null
dereference crash indicates it can be null. Since the existing logic is
only doing something if the ResumeAction field is not null, I assume
we similarly do nothing if the entire object is also null (since that
implies the former, too).

Fixes #1672

Not entirely sure why this can be the case, but a stacktrace from a null
dereference crash indicates it can be null. Since the existing logic is
only doing something if the `ResumeAction` field is not null, I assume
we similarly do nothing if the entire object is also null (since that
implies the former, too).
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyleejordan andyleejordan merged commit 2db050d into master Jan 19, 2022
@andyleejordan andyleejordan deleted the andschwa/fix-null-deref branch January 19, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Null dereference when debugging Pester tests
2 participants