Fixes @splatting in double quoted strings #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove #variable from #doubleQuotedString, remove @ from #variableNoProperty
|
Forgot to mention that this could use to have some test cases as well, both in double quoted strings (sample test included in #149) and in double quoted heredocs. |
|
I have added some tests for the issue this fixes, and also just-in-case for heredocs. I tested the 'tests' on the syntax prior to this PR to confirm they detect the failure for splats in double quoted strings, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #149, fixes #164
Include of
#variablewas removed from #doubleQuotedString, and a alternation of@was removed from a match in#variableNoPropertyfor variables that had a scope modifier.Double quoted HereDocs do not exhibit this problem, they do not include
#variable.I'm not noticing any side effects.
This makes no attempt to improve any other part of the variable logic (such as @splats are not allowed to have member access).