Skip to content

Colors on Monokai lost after upgrade to VSCode 1.26 #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PrzemyslawKlys opened this issue Aug 13, 2018 · 3 comments
Open

Colors on Monokai lost after upgrade to VSCode 1.26 #130

PrzemyslawKlys opened this issue Aug 13, 2018 · 3 comments

Comments

@PrzemyslawKlys
Copy link

Environment

  • Editor and Version (VS Code, Atom, Sublime): VSCode 1.26
  • Your primary theme: Monokai

Issue Description

Upgraded to 1.26 today, after restart things look weird...

Screenshots

image

Expected Behavior

Colorization should work as before.

@PrzemyslawKlys
Copy link
Author

Referencing #129 as while it talks about Insider release, it's not Insider anymore. Was released to public today.

@msftrncs
Copy link
Contributor

looking at #129, I have to disagree that the changes are all bad, though some changes were unexpected, the changes are making some things more like PowerShell ISE, while somethings have become broken, compared to PowerShell ISE. There are still some colorization that isn't working right, some of it is that themes don't colorize everything they probably should, and others are more complex like supporting subexpressions inside expandable strings really needs the ability to drop the string scope, or all themes to understand that its possible to have code inside a string.

I do believe there needed to be a little focus given to the themes that ship with VS Code, notably in this case, PowerShell ISE theme, as it no longer accomplishes some of the objectives (matching PowerShell ISE no less), and that would have helped the VS Code 1.26 release not be such a notable change.

See #132 for an example of something that still doesn't theme correctly (my opinion) due to scoping.

@PrzemyslawKlys
Copy link
Author

I am simply reporting issue. Whether it was needed or not that is not really my decision. I would like colors back but I can adjust. I’m not die hard against this change as VsCode has its own issues when I use it. So I can live few moments with problems as long in the long run it will be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants