Change Echo test resource to Microsoft.DSC.Debug/Echo resource
#553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
added
Doc-Impact
Schema-Impact
anmenaga
approved these changes
Sep 19, 2024
| #[derive(Debug, Parser)] | ||
| #[clap(name = "dscecho", version = "1.0.0", about = "Debugging helper resource that echos the input.", long_about = None)] | ||
| pub struct Args { | ||
| #[clap(short, long, help = "The input to the echo command as JSON. If no input is provided the JSON schema for the input is returned.")] |
There was a problem hiding this comment.
For a generic 'echo functionality' I don't think we should limit the input to be a JSON. It probably should be any string.
There was a problem hiding this comment.
What is echo'd doesn't have to be JSON, but the input has to be a valid JSON object that matches the resource schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Pull the functionality out of the
dsctestresource into a separateMicrosoft.DSC.Debug/EchoresourcePR Context
Fix #537