Skip to content

[Feature] - set line drop compensation to 0 by default #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 28, 2024
Merged

[Feature] - set line drop compensation to 0 by default #612

merged 5 commits into from
May 28, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented May 27, 2024 •
edited
Loading

Set line drop compensation to 0.0 when not provided

@mgovers mgovers added the feature New feature or request label May 27, 2024
@mgovers mgovers requested a review from nitbharambe May 27, 2024 13:49
mgovers added 2 commits May 27, 2024 15:50
@mgovers
minor
3b85e97 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
fix uninitialized line drop compensation
5cb6cac 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers marked this pull request as ready for review May 27, 2024 14:18
Base automatically changed from fix/different-node-ids to main May 27, 2024 15:05
@mgovers mgovers changed the title [Feature] - add different strategies validation cases for single trafo [Feature] - set line drop compensationbto 0 by default May 27, 2024
@mgovers mgovers changed the title [Feature] - set line drop compensationbto 0 by default [Feature] - set line drop compensation to 0 by default May 27, 2024
mgovers added 2 commits May 28, 2024 07:55
@mgovers
Merge remote-tracking branch 'origin/main' into feature/auto-tap-sing…
64d5439 
…le-transformer

Signed-off-by: Martijn Govers <[email protected]>
@mgovers
fix sonar cloud
c422472 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers enabled auto-merge May 28, 2024 05:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgovers mgovers added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit c1fbef5 May 28, 2024
@mgovers mgovers deleted the feature/auto-tap-single-transformer branch May 28, 2024 07:36
@mgovers mgovers mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitbharambe nitbharambe nitbharambe approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgovers @nitbharambe