-
Notifications
You must be signed in to change notification settings - Fork 43
Feature/default build #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
FYI: I did the following tests:
|
mgovers
commented
May 14, 2024
|
TonyXiang8787
approved these changes
May 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfr. https://youtu.be/xSrEHZ6Sgfg?si=et5_SnnpXRpxXE6A
it is good practice if you have potential users building from source that are not interested in things like tests, compiler warnings, etc. That is: the build should pass with default compiler settings initiated by
cmake -B build/ -S . cmake --build build/
and it should do so without any compiler warnings. Even more so, if one provides an install prefix or has the correct (admin) privileges for the default install prefix, installing should also pass. E.g.:
cmake -B build/ -S . -DCMAKE_INSTALL_PREFIX=install cmake --build build/ cmake --build build/ --target install
This also FINALLY disables the
-Wunused-attribute
warning that ClangCL raises.TBD: should we have (periodically scheduled?) builds that check whether these default builds pass?