Skip to content

fix performance regression #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024
Merged

fix performance regression #592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions power_grid_model_c/power_grid_model/include/power_grid_model/main_model.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,15 +665,12 @@ class MainModelImpl<ExtraRetrievableTypes<ExtraRetrievableType...>, ComponentLis

template <symmetry_tag sym>
auto calculate_power_flow(double err_tol, Idx max_iter, CalculationMethod calculation_method) {
auto const result_pf =
auto result_pf =
optimizer::get_optimizer<MainModelState, ConstDataset>(
OptimizerType::no_optimization, OptimizerStrategy::any, calculate_power_flow_<sym>(err_tol, max_iter),
[this](ConstDataset update_data) { this->update_component<permanent_update_t>(update_data); })
->optimize(state_, calculation_method);
if constexpr (std::is_same<decltype(result_pf), OptimizerOutput>::value) {
return MathOutput<SolverOutput<sym>>{.solver_output = {}, .optimizer_output = result_pf};
}
return MathOutput<SolverOutput<sym>>{.solver_output = result_pf, .optimizer_output = {}};
return MathOutput<SolverOutput<sym>>{.solver_output = std::move(result_pf), .optimizer_output = {}};
}

// Single load flow calculation, propagating the results to result_data
Expand Down