Skip to content

[Feature] elaborate null in JSON and nil in msgpack schemas #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 13, 2024
Merged

[Feature] elaborate null in JSON and nil in msgpack schemas #591

merged 6 commits into from
May 13, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented May 8, 2024

  • I found a small typo in the serialization docs.
  • I also tried to point someone to how nan values are represented and found it a little bit confusing, so I updated that logic as well.
  • Also made the distinction between null for JSON and nil/\xc0 for msgpack

@mgovers mgovers added the documentation Improvements or additions to documentation label May 8, 2024
@mgovers mgovers requested a review from nitbharambe May 8, 2024 08:29
@mgovers mgovers self-assigned this May 8, 2024
mgovers added 2 commits May 8, 2024 10:30
@mgovers
fix typo
faa7761 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
fix typo
ca50b01 
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers enabled auto-merge May 8, 2024 08:57
@mgovers mgovers requested a review from Jerry-Jinfeng-Guo May 8, 2024 13:21
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed May 8, 2024
View reviewed changes
mgovers added 2 commits May 13, 2024 08:20
@mgovers
Merge remote-tracking branch 'origin/main' into feature/elaborate-nul…
dd0ea70 
…l-in-serialization

Signed-off-by: Martijn Govers <[email protected]>
@mgovers
resolve comments
85bbbc6 
Signed-off-by: Martijn Govers <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mgovers mgovers added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit e629530 May 13, 2024
@mgovers mgovers deleted the feature/elaborate-null-in-serialization branch May 13, 2024 07:56
@mgovers mgovers mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo approved these changes

@nitbharambe nitbharambe nitbharambe approved these changes

Assignees

@mgovers mgovers

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgovers @Jerry-Jinfeng-Guo @nitbharambe