Skip to content

Renaming MathOutput to SolverOutput #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2024
Merged

Renaming MathOutput to SolverOutput #583

merged 2 commits into from
May 1, 2024

Conversation

Jerry-Jinfeng-Guo
Copy link
Contributor

Step 1 of the MathOutput transformation. Necessary for tap changer.

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo requested a review from mgovers May 1, 2024 10:27
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this May 1, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the feature New feature or request label May 1, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.5% Coverage on New Code
0.9% Duplication on New Code

See analysis details on SonarCloud

mgovers
mgovers reviewed May 1, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be a good idea to squash all commits after the final review is done but before adding it to the merge queue. this will filter out the commits that do a partial revert (particularly on main_model.hpp and test_main_model_*.cpp

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 7a54358 May 1, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/MathOutput-renamed-to-SolverOutput branch May 1, 2024 15:19
@mgovers mgovers mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers approved these changes

Assignees

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo

Labels
feature New feature or request
Projects
Power Grid Model
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jerry-Jinfeng-Guo @mgovers