Feature/container + main core improvements #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
mgovers
changed the title
nitbharambe
reviewed
Apr 26, 2024
power_grid_model_c/power_grid_model/include/power_grid_model/component/component.hpp
Show resolved
Hide resolved
nitbharambe
previously approved these changes
Apr 26, 2024
power_grid_model_c/power_grid_model/include/power_grid_model/calculation_parameters.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/calculation_parameters.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/component/component.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/math_state.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <[email protected]>
|
Jerry-Jinfeng-Guo
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More cherry-picking from #557
@nitbharambe
either before or after merge of this branch, the size checks from #562 can be removedEDIT: 8bf6a0b already removed thesizechecks for source. can you please have a look to verify that all of them have been removed?