-
Notifications
You must be signed in to change notification settings - Fork 43
Feature/auto tap changer skeleton #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
newly introduced sonar cloud issues are TODO's for follow-up tickets in this sprint |
@TonyXiang8787 can you also review please? |
power_grid_model_c/power_grid_model/include/power_grid_model/common/enum.hpp
Outdated
Show resolved
Hide resolved
In a call, @TonyXiang8787 has approved the overall design choices. This PR can be merged after someone else does a regular review |
Signed-off-by: Martijn Govers <[email protected]>
…m/PowerGridModel/power-grid-model into feature/auto-tap-changer-skeleton
power_grid_model_c/power_grid_model/include/power_grid_model/common/enum.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/optimizer/base_optimizer.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/optimizer/base_optimizer.hpp
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
|
This creates the skeleton for #74
NOTE: This is still in draft. I still need to create stub functions for the automatic tap optimizer
NOTE: Unfortunately, I had to make a few shortcuts to make sure I can unblock other people:
prepare_*_input
static
. For short circuit calculations, that is where the topology is constructed for fault components, which means a little bit more refactoring is necessary to move that part out ofMainModel
as well. I considered that out of scope of this PR and added aTODO
for follow-up due to the blocking nature of this PR.MainModel
is the object keeping track of the changes in state, which means I had to provide an update function to the optimizer.MainModel
registers anupdate_state(UpdateChange const&)
callback. That is out of scope of this PROther design considerations:
calculate_*
functions somewhat maintainable. If we would solve everything statically (like withMathSolver
) the amount of overloads forcalculate_*
would grow indefinitely, or we would not be able to refactor at a later stage.shared_ptr
because otherwise, ownership would be lost unless I would implement rule-of-five.shared_ptr
is actually able to use rule-of-zero without much overhead.