Quick patch on remaining issues on the docs. #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToDo: The hierarchy of batch datatypes is rather arbitrary and non-consistent, should we consider change that in the future? Signed-off-by: Jerry Guo <[email protected]>
…rray`. For ease, now `SingleArray` and `SingleDataset` are synonym, otherwise we have to change much more that necessary. Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
…PowerGridModel/power-grid-model into fix/numpy-array-indptr-datatype
…r-datatype Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
mgovers
reviewed
Mar 13, 2024
There was a problem hiding this comment.
if we want to move the contents of this file to core and then import the ones we need, we should use __all__ as mentioned in https://stackoverflow.com/questions/50585305/include-specific-imported-functions-in-sphinx-documentation
nitbharambe
reviewed
Mar 13, 2024
Signed-off-by: Martijn Govers <[email protected]>
nitbharambe
reviewed
Mar 13, 2024
|
nitbharambe
approved these changes
Mar 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToDo:
The hierarchy of batch datatypes is rather arbitrary and non-consistent, should we consider change that in the future?
Relates to #518 and #514
Preview in https://power-grid-model--521.org.readthedocs.build/en/521/api_reference/python-api-reference.html#power_grid_model.data_types.Dataset