extra trafo getters #507
Merged
extra trafo getters #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: petersalemink95 <[email protected]>
Signed-off-by: petersalemink95 <[email protected]>
Signed-off-by: petersalemink95 <[email protected]>
Signed-off-by: petersalemink95 <[email protected]>
Signed-off-by: petersalemink95 <[email protected]>
|
mgovers
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
@Jerry-Jinfeng-Guo and I are considering the possibility of letting the tap position regulator dictate that the transformer should calculate the calculation parameters with a different tap position instead of actively modifying the component. this enables that as well
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra getters to (3w) trafo that are needed for the automatic tap changer