feat: add nullstr option #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17367670895Details
💛 - Coveralls |
steve-chavez
force-pushed
the
to-1.0
branch
2 times, most recently
from
97eb3a9 to
73abc77
Compare
Otherwise installers can't replace the shared lib location by modifying the control file.
mul_size has an overflow guard
Split was done too early, keep modules simple for now. Also add some clarifying comments.
The string representing the null can now be specified.
```sql
SELECT csv_agg(x, csv_options(nullstr:='<NULL>')) AS body
FROM projects x;
body
--------------------------------
id,name,client_id +
1,Death Star OS,1 +
2,Windows 95 Rebooted,1 +
3,"Project ""Comma,Please""",2+
4,"Escape """"Plan""""",2 +
<NULL>,NULL & Void,<NULL>
(1 row)
```
Use a northwind database extract, remove unnecessary loadtests. Only one test using all the csv options in a single loadtest is necessary to ensure perf doesn't drop when adding new options. This makes the CI summary show fully instead of hiding some parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string representing the null can now be specified.
Also other refinements for reaching 1.0.