Skip to content

Conversation

mlachevre-pass
Copy link

Description

Currently if we enable "service: annotations:" annotations are template with wrong indentation and display this error.
Error: YAML parse error on posthog/templates/events-service.yaml: error converting YAML to JSON: yaml: line 8: did not find expected key
After fixing it (a bad space on the range declaration) we observed
Error: YAML parse error on posthog/templates/web-service.yaml: error converting YAML to JSON: yaml: line 14: did not find expected key
And in fact the indentation isn't ok.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Download chart locally
  • helmfile template without changing the templates folder
  • Updating events and web service
  • helmfile template doesn't return any yaml error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant