Skip to content

[MERGE]: ImageBanner Cell fix #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dongglehada merged 2 commits into from
Feb 23, 2025
Merged

[MERGE]: ImageBanner Cell fix #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3897ad
[FIX]: 메인베너 버전별 대응 처리
dongglehada Feb 23, 2025
c5cad69
[FIX]: 버전 18.3으로 수정
dongglehada Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions ...n/Scene/Home/Main/View/ImageBannerSection/ImageBannerSection/ImageBannerSectionCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ final class ImageBannerSectionCell: UICollectionViewCell {
controller.preferredIndicatorImage = UIImage(systemName: "circle")
controller.preferredCurrentPageIndicatorImage = UIImage(systemName: "circle.fill")
controller.isUserInteractionEnabled = false
controller.hidesForSinglePage = false
return controller
}()

Expand Down Expand Up @@ -214,9 +215,15 @@ extension ImageBannerSectionCell: Inputable {
func injection(with input: Input) {
if imageSection.isEmpty {
pageControl.numberOfPages = input.imagePaths.count
let stopButtonLeadingOffset = input.imagePaths.count == 3 ? -40 : input.imagePaths.count == 2 ? -36 : 0
stopButtonLeadingConstraints?.update(offset: stopButtonLeadingOffset)
playButtonLeadingConstraints?.update(offset: stopButtonLeadingOffset)
if #available(iOS 18.3, *) {
let stopButtonLeadingOffset = -26
stopButtonLeadingConstraints?.update(offset: stopButtonLeadingOffset)
playButtonLeadingConstraints?.update(offset: stopButtonLeadingOffset)
} else {
let stopButtonLeadingOffset = input.imagePaths.count == 3 ? -40 : input.imagePaths.count == 2 ? -36 : 0
stopButtonLeadingConstraints?.update(offset: stopButtonLeadingOffset)
playButtonLeadingConstraints?.update(offset: stopButtonLeadingOffset)
}
let datas = zip(input.imagePaths, input.idList)
let backContents = datas.suffix(1)
let frontContents = datas.prefix(1)
Expand Down