Support changing event type to listen to #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
while a small change, that does change the mixin into a generic "onAnythingOutside", so might actually be worth just spinning off as its own, more generic, mixin. |
|
I could live with it, but I'd rather not make a new repo that is 99% similar to this one. Are you a fan of this solution? |
austindebruyn
force-pushed
the
support-mouseup
branch
from
73fe764 to
352bf21
Compare
|
no, I don't want to have a project that's called "onclickoutside" lie about what it does. However, what we can do is start react-onoutsideevent, which I just have. If you want to refile your PR against that, then we can continue work there, and eventually retire this project instead. |
|
Fair enough, moved to Pomax/react-onoutsideevent#1 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where I'd like to listen to outside mouse releases, not presses. There's many ways to do it, but the least intrusive is to just allow a prop that sets the evt type to listen on. Thoughts?
Tested and works fine on desktop and mobile.