Fixed typo in GenerationIiiTypeSprites #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The serial name for rubySaphire seems to have changed in the API, which leads to getType(id) throwing an exception. The serial name was changed from "ruby-saphire" to "ruby-sapphire"
Member
|
Thanks for spotting it! Yes, the schema for the sprites has changed. @sargunv can you take a look? |
sargunv
approved these changes
Nov 18, 2025
Member
|
Thanks! I'll take a look at the failures and then cut a new release in a few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned in #158 the serial name for type sprites for ruby and sapphire seem to have changed in the API, which leads to
getType()throwing an exception.Changes
ruby-saphiretoruby-sapphireNote
Running the tests everything succeeds, except for Pokemon bulk fetching. It appears that the new mega evolutions from Legends ZA are missing many fields, like
baseExperience, which instead of a numeric value isnull. Since this was not caused by my changes and is not within the scope of the issue I fixed I will not fix this test case with this PR.