-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Components] appointo: Created polling source component new-booking-created #12933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
@jcortes is attempting to deploy a commit to the Pipedreamers Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent changes to the Changes
Sequence Diagram(s)sequenceDiagram
participant A as Client
participant B as Appointo API
participant C as New Booking Source
A->>B: Request new booking
B-->>A: Return booking confirmation
A->>C: Emit new booking created event
C->>A: Provide booking details
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (6)
- components/appointo/appointo.app.mjs (1 hunks)
- components/appointo/common/constants.mjs (1 hunks)
- components/appointo/common/utils.mjs (1 hunks)
- components/appointo/package.json (2 hunks)
- components/appointo/sources/common/polling.mjs (1 hunks)
- components/appointo/sources/new-booking-created/new-booking-created.mjs (1 hunks)
Files skipped from review due to trivial changes (1)
- components/appointo/common/constants.mjs
Additional comments not posted (15)
components/appointo/common/utils.mjs (1)
9-11: LGTM!The export statement is straightforward and correctly exports the
iteratefunction.components/appointo/package.json (2)
3-3: Version update is appropriate.The version update from
0.0.1to0.1.0is appropriate given the new functionality introduced.
15-18: Dependency addition is appropriate.The addition of the
@pipedream/platformdependency is appropriate for the new functionality introduced.components/appointo/sources/new-booking-created/new-booking-created.mjs (1)
1-1: LGTM!The import statement correctly imports common polling functions.
components/appointo/sources/common/polling.mjs (5)
8-18: LGTM! The properties section is well-defined.The
appproperty imports the Appointo app, and thetimerproperty sets up a polling schedule with a default interval.
23-25: LGTM! TheisResourceRelevantmethod is simple and effective.The method currently considers all resources relevant.
32-35: LGTM! TheprocessResourcemethod is well-implemented.The method generates metadata and emits the resource.
36-45: LGTM! TheprocessResourcesmethod is well-implemented.The method filters resources using
isResourceRelevantand processes them usingprocessResource.
47-61: LGTM! Therunmethod is well-implemented.The method retrieves and processes resources using
app.paginateandprocessResources.components/appointo/appointo.app.mjs (6)
9-11: LGTM! ThegetUrlmethod is well-implemented.The method constructs API request URLs by concatenating the base URL, version path, and the provided path.
12-17: LGTM! ThegetHeadersmethod is well-implemented.The method constructs API request headers by merging provided headers with the authorization token header.
18-26: LGTM! The_makeRequestmethod is well-implemented.The method centralizes the logic for making API requests using Axios, encapsulating URL and headers generation.
27-32: LGTM! ThelistBookingsmethod is well-implemented.The method retrieves booking data from the API using
_makeRequest.
33-72: LGTM! ThegetIterationsmethod is well-implemented.The method handles pagination by repeatedly fetching resources until a specified maximum count is reached or no more resources are available.
74-77: LGTM! Thepaginatemethod is well-implemented.The method integrates with utility functions to streamline iteration over paginated results.
michelle0927
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
WHY
Resolves #12871
Summary by CodeRabbit
New Features
Improvements
Version Update