Handle Wine archives with directory #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madoar
reviewed
May 17, 2018
| .extract(); | ||
|
|
||
| var files = ls(localDirectory); | ||
| if (files.length == 1) { |
Collaborator
There was a problem hiding this comment.
Is it ensured that the single file is a directory and not some other file like a zip archive?
Collaborator
Author
There was a problem hiding this comment.
No, but this whole code is rather heuristic e.g. it will not make sense if the directory is not really the extracted Wine directory.
madoar
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #624 and #621
fixes #623