Skip to content

Some deduplications in parser #23838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: blead
Choose a base branch
from
Open

Some deduplications in parser #23838

wants to merge 2 commits into from
+388 −378

Conversation

happy-barney
Copy link

@happy-barney happy-barney commented Oct 12, 2025 •
edited
Loading

Internal changes - move duplicated code into dedicated functions.

  • This set of changes does not require a perldelta entry.

tonycoz
tonycoz reviewed Oct 12, 2025
View reviewed changes
embed.fnc Outdated
Comment on lines 2489 to 2490
p |void |package_v544 |NN OP *o \
|NULLOK OP *v
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be called "package2()" if you're going for a non-descriptive new name.

Otherwise package_with_version() or package_and_version() seem more reasonable then either.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, that's what I forgot in PR message ... updated.

Honestly, I prefer API version in another version of function - it clearly says when it was added without need to consult additional tools (which in fact are not aware of semantics)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonycoz Perl_package changed, original functions are now static and new function remains package

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename S_package (maybe S_package_named) to keep the base name distinct from Perl_package.

@tonycoz
Copy link
Contributor

tonycoz commented Oct 19, 2025

Documentation build warnings:

'new_block_statement' missing 'd' flag at embed.fnc, line 2292 at autodoc.pl line 2784.
'package' missing 'd' flag at embed.fnc, line 2562 at autodoc.pl line 2784.

@happy-barney
Copy link
Author

@tonycoz done

Branislav Zahradník added 2 commits October 20, 2025 11:22
[parser] package - deduplicate coupled call sequence
f3fc976 
Function combines call of original `package` and `package_version` when
new namespace statement is detected.

Instead of required three statements usage now consists of single function call.
[parser] new_block_statement - deduplicate "a block is a loop that ha…
8715272 
…ppens once"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonycoz tonycoz tonycoz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@happy-barney @tonycoz