Skip to content

Accept TiDB Global Index column #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rewrite
Choose a base branch
from

Conversation

mjonss
Copy link

@mjonss mjonss commented May 22, 2025

Added handling of the extra column in TiDB 8.5 for Global Index during

SHOW INDEXES FROM `%s`.`%s`

@ylacancellera
Copy link
Collaborator

@mjonss Thanks for your contribution.
I am currently analyzing the rewrite branch and I am interested about your change:
Ultimately, what does having this extra index handled by mysql_random_data_load enable for you ?

Indexes are stored based on the "table" struct, but there's not so much usage of it. I'd like to understand better how this impacts TIDB usage, I would appreciate if you can help me understand

@mjonss
Copy link
Author

mjonss commented Jun 10, 2025

@mjonss Thanks for your contribution. I am currently analyzing the rewrite branch and I am interested about your change: Ultimately, what does having this extra index handled by mysql_random_data_load enable for you ?

Indexes are stored based on the "table" struct, but there's not so much usage of it. I'd like to understand better how this impacts TIDB usage, I would appreciate if you can help me understand

@ylacancellera "having" this index is not useful, but allowing mysql_random_data_load to work with the extended output from TiDB's SHOW INDEXES allows it to also be used for TiDB :)

What I am trying to say is that all that is needed is to allow more columns in the output from SHOW INDEXES, they can be ignored, but the current implementation seems to need to parse them from the output, through row.Scan(fields...).

@ylacancellera
Copy link
Collaborator

@mjonss so that you know: there should be in the near future (probably few weeks) a fork of this project in a new repo.
This is to merge this branch and to add pg support amount other improvments. It is not using SHOW INDEXES anymore, so I would imagine it will work for tidb as you expect, though I did not test.

Thanks for your contribution

@mjonss
Copy link
Author

mjonss commented Jun 17, 2025

Please feel free to close this when the new repo is launched. I also have some ideas generate data according to gathered statistics from TiDB or MySQL or MariaDB. So I'm interested in the new repo :) This would help troubleshooting optimizer issues, test plans and validate ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants