-
Notifications
You must be signed in to change notification settings - Fork 0
Add ipk package builder script and makefile target #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that creating ipk files is manual. That seems to have an annoying amount of boilerplate, and will be used in at least 3 repos. I suggest:
- Putting
control
as a flat text file in the root of the repo (maybe namedipk-control
?) - Making a python package called
ipk-build
package on pypi that has a singleipk-build
entrypoint that does the same as this script - Installing it into the devcontainer along with all the other python deps
- Calling it from the makefile in this repo and other places that need to make ipk files
Please can you prototype this as a single python script ipk-build.py
in this repo and we'll take it from there
I suggest adding it as a submodule and calling it from there then (it doesn't seem to be published on pypi) |
OK, I've done a similar change to the one in the FPGA repo, the packaging related files are under |
850b2fc
to
e5ec639
Compare
I think that script is only used in this repo, because all the other GitHub releases are made by CI in GitHub. This is the only one that requires pushing locally, so unless you can find any other references in other repos you can move that script to this repo. |
a474d48
to
03aca0d
Compare
The advantages are: - The ipk build script is smaller. - The metadata is validated. The disadvantage is having an extra dependency which in this case is in the form of a submodule.
03aca0d
to
379cf11
Compare
Done! it turned out that |
379cf11
to
e14b187
Compare
The IPK package will be used in the yocto rootfs.