-
Notifications
You must be signed in to change notification settings - Fork 287
[V3] Refactor theme package to Typescript #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V3] Refactor theme package to Typescript #684
Conversation
Checked the The flattening of children now has been fixed as well. Typing makes me think this might not be necessary, but it has probably been introduced with a reason (I cannot find more information on why it was introduced). Everything seems to be working fine, and the small bugs mentioned have been fixed as well. |
I also noticed an issue with d805ac9 where the sidebar typing is not actually exported from Docusaurus. Fixed this in the last commit. |
Visit the preview URL for this PR (updated for commit ced955b): https://docusaurus-openapi-36b86--pr684-bsjeg26x.web.app (expires Sat, 03 Feb 2024 20:44:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Description
Removed (almost) all javascript files from the
docusaurus-theme-openapi-docs
and converted them to typed react components. Also fixed the highlighting of codeblocks and a small issue with the clean method.There are still a few TODOs regarding code that did not work anymore due to typing. I could not figure out what this code did so I left it commented out with
//TODO Gijs
for now. Will take a look at it later. Furthermore, there are a few properties that have not been typed completely as I wanted to prevent copying typing from thedocusaurus-plugin-openapi-docs
as much as possible (and was unsure how to do this properly).Some of the updated code has been gotten directly from the official Docusaurus repository which now fully supports Typescript.
Still has to be rebased properly.
Motivation and Context
How Has This Been Tested?
Behaviour of the refactored components was compared to those of the original ones. No difference in functionality could be noticed.
Types of changes
Checklist