Skip to content

Conversation

@plusNew001
Copy link
Collaborator

Motivation

Modifications

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

Set pip global index URL to Tsinghua mirror and uninstall PaddleCustomDevice and fastdeploy.
Copilot AI review requested due to automatic review settings November 18, 2025 12:47
@paddle-bot
Copy link

paddle-bot bot commented Nov 18, 2025

Thanks for your contribution!

Copilot finished reviewing on behalf of plusNew001 November 18, 2025 12:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the pip configuration setup in the HPU CI script by moving the pip index URL configuration to execute before installing requirements, rather than after uninstalling packages. This ensures the correct PyPI mirror is used for all subsequent pip installations.

Key Changes

  • Moved pip index-url configuration to line 18, before requirements.txt installation
  • Removed duplicate pip index-url configuration from line 26 (previously after uninstall commands)

lsof -t -i :$FD_API_PORT | xargs kill -9 || true

echo "pip requirements"
python -m pip config set global.index-url https://pypi.tuna.tsinghua.edu.cn/simple
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title "[HPU][CI]Hpu ci update" lacks a clear description of what is being updated. According to the project guidelines, the title should follow the format [CLASS]Title with a descriptive summary. Consider changing it to something like "[HPU][CI]Move pip mirror configuration before requirements installation" to better describe the specific change being made.

Copilot generated this review using guidance from repository custom instructions.
lsof -t -i :$FD_API_PORT | xargs kill -9 || true

echo "pip requirements"
python -m pip config set global.index-url https://pypi.tuna.tsinghua.edu.cn/simple
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is incomplete. According to the project guidelines, the description should at minimum explain why these modifications are being made and what problem is being solved. Please add details about why moving the pip configuration earlier in the script is necessary (e.g., to ensure requirements.txt dependencies are downloaded from the Tsinghua mirror for better performance/reliability in the CI environment).

Copilot generated this review using guidance from repository custom instructions.
@plusNew001 plusNew001 merged commit 3e3558f into PaddlePaddle:develop Nov 20, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant