-
Notifications
You must be signed in to change notification settings - Fork 660
[Polish] Polish error message #5081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
|
|
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR polishes error messages and refactors logger usage throughout the codebase. The primary goals are to improve error message clarity when KV cache resources are insufficient and standardize logger usage by replacing the generic logger with more specific llm_logger and console_logger instances.
Key changes:
- Replaced assertion with explicit error handling and improved error message for KV cache resource exhaustion
- Standardized logger usage across the config module by replacing
loggerwithllm_loggerandconsole_logger - Added support for a new splitwise version (v2) with router and local scheduler configuration
- Suppressed paddleformers INFO-level logging by setting log level to ERROR
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| fastdeploy/config.py | Refactored logger usage from generic logger to specific llm_logger/console_logger; improved KV cache error message with actionable information; added v2 splitwise configuration support with validation; added innode_prefill_ports parameter support |
| fastdeploy/init.py | Changed paddleformers logger level from INFO to ERROR to suppress less critical logs; added warning filter for paddleformers module |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Motivation
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.