Skip to content

Conversation

@zulus
Copy link

@zulus zulus commented Feb 13, 2013

pdt-eg/Core-Plugin#22

pdt 3.2.1 will be released after 9 days
In this version, new parameter (phpVersion) is not used

@skiera
Copy link
Member

skiera commented Feb 14, 2013

Thanks for your commit. I will test it soon.

@bglase
Copy link

bglase commented Mar 22, 2013

By the way, at the moment PDT is not using the phpVersion parameter; however it looks like adding this fragment to zulus' branch will get the actual PHP version (as opposed to hardcoding it):

    // Detect PHP version by finding our executable and asking it
    String phpV = null;
    PHPexeItem[] items = PHPexes.getInstance().getAllItems();
    for (PHPexeItem item : items) {
        if (item.getExecutable().equals(phpExeFile)) {
            phpV = item.getVersion();
            break;
        }
    }

    String[] cmdLine = PHPLaunchUtilities.getCommandLine(
            launch.getLaunchConfiguration(),
            OperatingSystem.escapePHPFileArg(phpExeString), phpConfigDir,
            OperatingSystem.escapeShellFileArg(fileName), args, phpV);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants