Skip to content

Conversation

@lucasnetau
Copy link
Contributor

@lucasnetau lucasnetau commented Dec 2, 2021

  • Handle a wildcard match that contains a forward slash in the pattern by adding / to the delimiter list of preg_quote
  • Fix SUMIF doing a wildcard match on empty cells (NULL)
  • Fix compare logic to return false when value is an empty string or NULL (Verified against LibreOffice SUMIF and MATCH handling of empty cells)

Fixes #2430

This is:

- [X ] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

Correct support for Wildcard searches in SUMIF and MATCH

lucasnetau and others added 2 commits December 2, 2021 22:24
* Handle a wildcard match that contains a forward slash in the pattern by adding / to the delimiter list of preg_quote
* Fix SUMIF doing a wildcard match on empty cells (NULL)
* Fix compare logic to return false when value is an empty string or NULL (Verified against LibreOffice SUMIF and MATCH handling of empty cells)
@oleibman
Copy link
Collaborator

oleibman commented Dec 4, 2021

Thank you for your contribution.

@oleibman oleibman merged commit e01a81e into PHPOffice:master Dec 4, 2021
@lucasnetau lucasnetau deleted the wildcard_2430 branch December 5, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Wildcard searches fails with empty cells and those with forward slashes in wildcard

2 participants