Undefined index $ : while importing excel file

[sidrafarooq]

This is:

-  a bug report

What is the expected behavior?

Trying to import an excel file (.xlsx) and file should be imported without any error

What is the current behavior?

During import i am getting undefined index $ error (IOFactory::load method is throwing this error) when i searched it, its because of autoFilter being applied.

2018-09-26 07:05:22 : #0 /var/www/html/project/vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Cell/Coordinate.php(291): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError(8, 'Undefined index...', '/var/www/html/s...', 291, Array)
#1 /var/www/html/project/vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Cell/Coordinate.php(207): PhpOffice\PhpSpreadsheet\Cell\Coordinate::columnIndexFromString('$A')
#2 /var/www/html/project/vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Worksheet/AutoFilter.php(111): PhpOffice\PhpSpreadsheet\Cell\Coordinate::rangeBoundaries('$A$1:$K$1')
#3 /var/www/html/project/vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Reader/Xlsx.php(1076): PhpOffice\PhpSpreadsheet\Worksheet\AutoFilter->setRange('$A$1:$K$1')
#4 /var/www/html/project/app/Excel/FileLoader.php(286): PhpOffice\PhpSpreadsheet\Reader\Xlsx->load('/var/www/html/s...')

What are the steps to reproduce?

just upload an excel file downloaded through phpspreadsheet all filters applied (autoFilter are like this $A$1:$K$1 the dollar sign is creating problem when used in Coordinate.php line 291)

<?php

require __DIR__ . '/vendor/autoload.php';

$reader = IOFactory::createReaderForFile($file_name);
$excel    =   $reader->load($file_name);

Which versions of PhpSpreadsheet and PHP are affected?

Latest
1.4.0

[PowerKiKi]

Can be easily reproduced with:

<?php
require 'vendor/autoload.php';

var_dump(\PhpOffice\PhpSpreadsheet\Cell\Coordinate::columnIndexFromString('$A'));

PR welcome to fix it

[sidrafarooq]

@PowerKiKi i fixed it by removing "$" sign.

$autoFilterRange = str_replace("$", "", $autoFilterRange);

at line: /var/www/html/project/vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Reader/Xlsx.php(1076): PhpOffice\PhpSpreadsheet\Worksheet\AutoFilter->setRange('$A$1:$K$1')

so the values passed within setRange is "A1:K1"

and as we cant change the library directly so we added patch so that changes can persist themselves whenever we ran composer install or update.

For now library is working okay.

[yudina-m]

I created PR with suggested change and also added an Exception to Coordinate::columnIndexFromString, similar to the symbol limit. Unit tests are updated as well.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.