Fix Html::parseImage when image has no extension #2459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JokubasR
force-pushed
the
fix/html-image-parser
branch
from
b9a0dff to
db0fb5e
Compare
|
@JokubasR Thank you for your contribution. Could you update the |
Progi1984
approved these changes
Sep 3, 2023
JokubasR
force-pushed
the
fix/html-image-parser
branch
from
db0fb5e to
dcb6ba9
Compare
JokubasR
force-pushed
the
fix/html-image-parser
branch
from
dcb6ba9 to
03246d7
Compare
|
Progi1984 Ok, sure. Hope it's alright now |
Progi1984
approved these changes
Sep 3, 2023
|
@JokubasR Thank you for your contribution 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow image from url without extension. Currently it throws an
Undefined array key 1error.Fixes #2458
Checklist:
composer run-script check --timeout=0and no errors were reported