Skip to content

Font-style addition: bgColor #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Font-style addition: bgColor #145

wants to merge 5 commits into from

Conversation

jcarignan
Copy link

  • Meant to replace fgColor, can now use any hex color instead of the 15 constants FGCOLOR_xyz in Font.php
  • Preserve spaces after text fixed (Base.php line 78)
  • usage: $section->addText(" myText ", array("bgColor" => "112233"));

Julien Carignan added 3 commits March 18, 2014 11:06
Font-style addition: bgColor
324e15a 
- Meant to replace fgColor, can now use any hex color instead of the 15 constants FGCOLOR_xyz in Font.php
- Preserve spaces after text fixed (Base.php line 78)

Signed-off-by: Julien Carignan <[email protected]>
When saving as "php://output", we want its content-length. Tmp file s…
bcdb9c0 
…hould go into sys_get_temp_dir() instead of "./"

Signed-off-by: Julien Carignan <[email protected]>
Added height rules for table row, mostly for removing the added space…
3b1013e 
… after a table

- Code mostly come from this discussion: https://phpword.codeplex.com/discussions/440933
- Adapted and works for 0.8.1
- Usage: $table->addRow(5000, $rowStyle, "exact");

Signed-off-by: Julien Carignan <[email protected]>
@Progi1984 Progi1984 added this to the 0.9.0 milestone Mar 18, 2014
@Progi1984
Copy link
Member

@jcarignan Could you add some unit Tests and a sample ?

Julien Carignan added 2 commits March 18, 2014 12:13
@jcarignan
Copy link
Author

Just added 2 samples, I'm not sure what to add in the Tests folder, désolé!

@ivanlanin
Copy link
Contributor

I suggest we hold this until #58 resolved.

@Progi1984
Copy link
Member

@jcarignan Could you update your code with the develop branch, plz ?

@Progi1984 Progi1984 removed this from the 0.9.0 milestone Mar 24, 2014
@jcarignan
Copy link
Author

@Progi1984 Done, sorry for pulling to the wrong branch! #168

@ivanlanin
Copy link
Contributor

Good addition @jcarignan. Thanks. I would like to suggest us to use Style\Row along with tblHeader and cantSplit. They are all child nodes of w:trPr. That way, we won't pass too many parameters to addRow, e.g. addRow(null, array('tblHeader' => true, 'hRule' => 'exact')).

For the bgColor, it will be interesting to elaborate the use of this w:shd node. For the mean time, we could use this.

@Progi1984 Progi1984 added this to the 0.9.1 milestone Mar 26, 2014
@Progi1984
Copy link
Member

I close this one. Go #168 !

@Progi1984 Progi1984 closed this Mar 26, 2014
@ivanlanin
Copy link
Contributor

@Progi1984 I haven't merged this pull :) Have you?

@ivanlanin ivanlanin reopened this Mar 26, 2014
@Progi1984
Copy link
Member

No. But this PR points to master. #168 points to develop. It's why I close this one.

@Progi1984 Progi1984 closed this Mar 26, 2014
@ivanlanin
Copy link
Contributor

Ok :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ivanlanin ivanlanin

Labels
Change Request Open XML (Word 2007+)
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jcarignan @Progi1984 @ivanlanin