Skip to content

Wrong unit in image style documentation #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2018
Merged

Wrong unit in image style documentation #1339

merged 2 commits into from
Apr 13, 2018

Conversation

Trainmaster
Copy link
Contributor

Description

According to the change in #874 the unit now is pt.

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have update the documentation to describe the changes

@Trainmaster
Copy link
Contributor Author

@troosan Shouldn't the fix 3f40c5e parse px as pt?

@Trainmaster Trainmaster force-pushed the feature-wrong-unit-in-image-doc branch from 1bcba19 to 833cf07 Compare April 12, 2018 14:59
@troosan troosan merged commit 3380aa8 into PHPOffice:develop Apr 13, 2018
@Trainmaster Trainmaster deleted the feature-wrong-unit-in-image-doc branch April 17, 2018 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trainmaster @troosan