This is 2012, assume already have UTF8 #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are conversion functions scattered around that assume text is ISO-8859-1, and does conversion to UTF-8. PHPWord should assume text is already in UTF-8, and let calling applications do charset conversions if required.
|
I completely agree. I had to comment all the statements. |
|
I have the same problem, all my text is already in utf8. The internal conversions should either be removed or made optional via some configuration flag or such. Although the former seems much more flexible to me. |
|
A test for knowing if the text is in UTF-8 would be a solution. It's why PHPWord_Shared_String::IsUTF8() exists. |
|
I just commited a improvement. Now, i test if text is in UTF-8 before converting to UTF-8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are conversion functions scattered around that assume text is
ISO-8859-1, and does conversion to UTF-8. PHPWord should assume text is
already in UTF-8, and let calling applications do charset conversions if
required because otherwise there is dataloss.
Fixes issue #9