Skip to content

Conversation

1nf0rmagician
Copy link
Member

No description provided.

@1nf0rmagician
Copy link
Member Author

@Toxantron was this something you still wanted to go through with or was it neglected for a reason? 🤔

@Toxantron
Copy link
Member

Would like to, especially now in one repo.

@dbeuchler
Copy link
Member

I have another one:

IMarkiungLaserDriver

        void RequestLastError();
        void RequestLastWarning();

        event EventHandler<NotificationResponse> ErrorOccured;
        event EventHandler<NotificationResponse> WarningOccured;

.. are always not implemented in my laser drivers (Foba, ACI) - it was just for an implementation of a specific manufacturer. Errors/Warnings should always be a response of the actions (Mark, SetMArkingFile) - other state changes should be raised by the driver-state-change.

Are there other votes for removal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants