Skip to content

Conversation

kshitij-k-osmosys
Copy link
Contributor

@kshitij-k-osmosys kshitij-k-osmosys commented Jun 15, 2025

API PR Checklist

Task Link

Osmosys Developers must include the Pinestem task link in the PR.

REST-1548

Pre-requisites

  • I have gone through the Contributing guidelines for Submitting a Pull Request (PR) and ensured that this is not a duplicate PR.
  • I have performed preliminary unit testing.
  • I have updated the required api docs as applicable.
  • I have added/updated test cases to the test suite as applicable

PR Details

PR details have been updated as per the given format (see below)

  • PR title adheres to the format specified in guidelines (e.g., feat: add admin login endpoint)
  • Description has been added
  • Related changes have been added (optional)
  • Screenshots have been added (optional)
  • Query request and response examples have been added (as applicable, in case added or updated)
  • Documentation changes have been listed (as applicable)
  • Test suite output is added (as applicable)
  • Pending actions have been added (optional)
  • Any other additional notes have been added (optional)

Additional Information

  • Appropriate label(s) have been added (ready for review should be added if the PR is ready to be reviewed)
  • Assignee(s) and reviewer(s) have been added (optional)

Description:

Upgrade Transcript Summarization API to use node 22 for bundling the application

Related changes:

  • Update package.json and package-lock.json to build using node 22
  • Update Dockerfile to build using node 22 image
  • Update CI to use node 22

Screenshots:

image

Summary by CodeRabbit

  • Chores
    • Updated the backend environment to use Node.js version 22.
    • Adjusted container startup commands for improved compatibility.

Copy link
Contributor

coderabbitai bot commented Jun 15, 2025

Walkthrough

The updates transition the backend environment from Node.js version 20 to version 22. This includes changes to the GitHub Actions workflow, Dockerfile, and the Node.js engine requirement in the package.json. Additionally, the Dockerfile's CMD instruction was modified for improved shell context handling.

Changes

Files/Paths Change Summary
.github/workflows/backend.yml Updated Node.js version from 20 to 22 in workflow jobs.
apps/api/Dockerfile Changed base image to Node.js 22 and updated CMD to use shell context for background process.
apps/api/package.json Updated Node.js engine requirement from 20.x to 22.x.

Suggested labels

Ready for review, dependencies

Suggested reviewers

  • xixas
  • osm-vishnukyatannawar

Poem

Upgraded Node, the backend’s new delight,
From twenty to twenty-two, it’s running just right.
Docker and workflows, all tuned with care,
The rabbit hops forward, fresh code in the air!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20c4b8b and d7bac98.

⛔ Files ignored due to path filters (1)
  • apps/api/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • .github/workflows/backend.yml (2 hunks)
  • apps/api/Dockerfile (2 hunks)
  • apps/api/package.json (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/backend.yml

14-14: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)


17-17: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)


33-33: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)


36-36: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🔇 Additional comments (5)
apps/api/package.json (1)

8-10: Upgrade Node.js engine to 22.x
Aligns the engine requirement with the updated runtime in Docker and CI.

.github/workflows/backend.yml (2)

17-19: Use Node.js 22 in lint job
Ensures the lint step runs under the upgraded Node.js version.

🧰 Tools
🪛 actionlint (1.7.7)

17-17: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)


36-39: Use Node.js 22 in build job
Keeps build consistency with the new Docker base image and engine requirement.

🧰 Tools
🪛 actionlint (1.7.7)

36-36: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

apps/api/Dockerfile (2)

1-2: Bump base Docker image to Node.js 22
Matches the engine version specified in package.json and CI workflows.


29-29: Switch to exec-form CMD with shell
Using ["sh","-c", ...] ensures the scheduler runs correctly in the background.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kshitij-k-osmosys kshitij-k-osmosys added Ready for review Ready for review dependencies Pull requests that update a dependency file and removed Ready for review Ready for review labels Jun 15, 2025
@osm-vishnukyatannawar osm-vishnukyatannawar merged commit 0196781 into main Jun 23, 2025
6 checks passed
@osm-vishnukyatannawar osm-vishnukyatannawar deleted the build/upgrade-to-node-22 branch June 23, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Ready for review Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants