-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add TypeORM MariaDB Integration and DB Migration #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning Rate Limit Exceeded@ramraut-osm has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 31 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe update enhances the API's structure and tooling for improved development workflows and database management. Key changes include schema refinement by removing Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
apps/api/docs/database-design.md (1)
Line range hint
13-46
: Ensure the database design document is accurate and grammatically correct.Consider starting sentences with uppercase letters and checking for repeated whitespaces in the data dictionary.
- - **files :** Contains details about all the user uploaded files with their Task IDs. - - **jobs:** Contains details about the queue system-related data, such as job metadata and status. + - **Files:** Contains details about all the user uploaded files with their Task IDs. + - **Jobs:** Contains details about the queue system-related data, such as job metadata and status.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramraut-osm Make the mentioned changes.
Also let me know if you ran the migrations and saw the tables in DB.
You have checked the following but have not done it. Don't see any label
Appropriate label(s) have been added (ready for review should be added if the PR is ready to be reviewed)
Developer will add the label, reviwer will remove it if there are changes needed before assigning back to dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Out of diff range and nitpick comments (1)
apps/api/docs/development-setup.md (1)
64-74
: Consider adding troubleshooting tips for database setup.The instructions for running database migrations are clear. However, adding a section on troubleshooting common issues during database setup could greatly assist new developers. Common issues might include connection errors or migration failures.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
API PR Checklist
Pre-requisites
PR Details
PR details have been updated as per the given format (see below)
feat: add admin login endpoint
)Additional Information
ready for review
should be added if the PR is ready to be reviewed)Description:
Added TypeORM MariaDB Integration with Added DB Migration for Storing Job Details.
Related changes:
Summary by CodeRabbit
Summary by CodeRabbit
jobs
andfiles
tables in the database.file_id
attribute from the database schema.