Skip to content

Conversation

ernestognw
Copy link
Member

@ernestognw ernestognw commented Jan 28, 2025

The #typo-fixes branches accumulated typo fixes. This branch should be merged before freezing a release candidate.
This is done to avoid multiple small commits on that polute the master branch. All typo fix PR should target this branch.

Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 04da5e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx mentioned this pull request Feb 4, 2025
@Amxx Amxx added the typo label Feb 12, 2025
@Amxx Amxx added this to the 5.3 milestone Feb 14, 2025
Comment on lines 20 to 21

# Disclaimer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been against changing archived audits but if consensus is we should change it, that's fine.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is consensus. Just grouping everything under one PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we shouldn't change the audits. However, in this case I'm starting to lean towards changing it just because it's the most pragmatic decision to avoid having more bot PRs in the future. We've already closed and discussed this a couple of times.

arr00
arr00 previously approved these changes Feb 28, 2025
@Amxx Amxx mentioned this pull request Mar 6, 2025
@Amxx Amxx merged commit ca7a4e3 into master Mar 6, 2025
17 checks passed
@Amxx Amxx deleted the typo-fixes branch March 6, 2025 08:58
Amxx added a commit that referenced this pull request Mar 6, 2025
Co-authored-by: Bilog WEB3 <[email protected]>
Co-authored-by: Fallengirl <[email protected]>
Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: XxAlex74xX <[email protected]>
Co-authored-by: Arr00 <[email protected]>
Co-authored-by: PixelPilot <[email protected]>
Co-authored-by: kilavvy <[email protected]>
Co-authored-by: Devkuni <[email protected]>
Co-authored-by: Danbo <[email protected]>
Co-authored-by: Ann Wagner <[email protected]>
Co-authored-by: comfsrt <[email protected]>
Co-authored-by: Bob <[email protected]>
Co-authored-by: JohnBonny <[email protected]>
Co-authored-by: moonman <[email protected]>
Co-authored-by: kazak <[email protected]>
Co-authored-by: Wei <[email protected]>
Co-authored-by: Maxim Evtush <[email protected]>
Co-authored-by: Vitalyr <[email protected]>
Co-authored-by: pendrue <[email protected]>
Co-authored-by: Tronica <[email protected]>
Co-authored-by: emmmm <[email protected]>
Co-authored-by: bigbear <[email protected]>
Co-authored-by: Tomás Andróil <[email protected]>
Co-authored-by: GooseMatrix <[email protected]>
Co-authored-by: jasmy <[email protected]>
Co-authored-by: SITADRITA1 <[email protected]>
Co-authored-by: Ocenka <[email protected]>
Signed-off-by: Hadrien Croubois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.