-
Notifications
You must be signed in to change notification settings - Fork 6
RWA docs for Stellar #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for openzeppelin-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Just merged #57 so feel free to continue! |
6bb0959 to
57a3d63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You provide a good high-level overview of the system. My suggestion is to include more content defining the terms, because they might not be obvious as a meaning. I'm also wondering if it might be a good idea to include a mermaid-style of chart for the basic flow as it will make clear how different parts of the system interact with each other (ref. relayer docs)
Add RWA to navigation https://github.com/OpenZeppelin/docs/blob/main/src/navigation/stellar.json
3d73d91 to
e8f6c05
Compare
Co-authored-by: Boyan Barakov <[email protected]>
Co-authored-by: Boyan Barakov <[email protected]>
8800bad to
5eabda0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ozgunozerk approving the PR, great job 🙌
One last thing, I believe that adding a sequence diagram similar to this one at the end of "Modules" section can be a great addition: after going through all the modules, here's how everything works together. Leaving it up to you.
Draft, because I've only added the main content.
Will adjust the links and other things after #57 finalizes.