Update report update condition to use report ID #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple identical reports are submitted, there can be a race condition where a report is committed for that node during the time the second report is being processed and they are both trying to be set as the latest report, resulting in a duplicate report being stored. This causes any subsequent report submissions to fail for that node. This fixes the problem by using the latest-report-id calculated when the function is called, using its timestamp to decide if this report is in fact the latest report. Fixes #16.
bastelfreak
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple identical reports are submitted, there can be a race condition where a report is committed for that node during the time the second report is being processed and they are both trying to be set as the latest report, resulting in a duplicate report being stored. This causes any subsequent report submissions to fail for that node. This fixes the problem by using the latest-report-id calculated when the function is called, using its timestamp to decide if this report is in fact the latest report.
Fixes #16.