feat: use openvox repo instead single deb files #3
Conversation
| ADD https://apt.overlookinfratech.com/openvox${OPENVOX_RELEASE}-release-ubuntu${UBUNTU_VERSION}.deb / | ||
| RUN apt-get update && \ | ||
| apt-get install -y ca-certificates && \ | ||
| dpkg -i /openvox${OPENVOX_RELEASE}-release-ubuntu${UBUNTU_VERSION}.deb && \ | ||
| rm /openvox${OPENVOX_RELEASE}-release-ubuntu${UBUNTU_VERSION}.deb |
There was a problem hiding this comment.
If you have this in 2 commands, won't this end up in a layer that is still shipped to the end user?
There was a problem hiding this comment.
yes. this was more like a test if i can somehow cache this layer in build time... but it does not.
| apt-get install -y openvox-agent=${OPENVOXAGENT_VERSION}-1+ubuntu${UBUNTU_VERSION} && \ | ||
| apt-get install -y openvox-server=${OPENVOXSERVER_VERSION}-1+ubuntu${UBUNTU_VERSION} && \ | ||
| apt-get install -y openvoxdb-termini=${OPENVOXDB_VERSION}-1+ubuntu${UBUNTU_VERSION} && \ |
There was a problem hiding this comment.
Do you need to specify the exact package name like this? By hardcoding -1 you're making sure you can't use releases to patch small things. Also, probably better to run it in a single apt-get install command. The server can pull in a different agent version and might up-/downgrade it this way. I suspect that with a single command it'll refuse to run instead. You can probably even combine it with $PACKAGES
There was a problem hiding this comment.
i don't know how to better pin the version. i tried package=version but this didnt work until i added the rest :(.
There was a problem hiding this comment.
Some experimentation tells me apt install openvox-agent=8.11.0-* works for me so I think this should work:
| apt-get install -y openvox-agent=${OPENVOXAGENT_VERSION}-1+ubuntu${UBUNTU_VERSION} && \ | |
| apt-get install -y openvox-server=${OPENVOXSERVER_VERSION}-1+ubuntu${UBUNTU_VERSION} && \ | |
| apt-get install -y openvoxdb-termini=${OPENVOXDB_VERSION}-1+ubuntu${UBUNTU_VERSION} && \ | |
| apt-get install -y openvox-agent=${OPENVOXAGENT_VERSION}-* openvox-server=${OPENVOXSERVER_VERSION}-* openvoxdb-termini=${OPENVOXDB_VERSION}-* && \ |
| ADD https://apt.overlookinfratech.com/openvox${OPENVOX_RELEASE}-release-ubuntu${UBUNTU_VERSION}.deb / | ||
| RUN apt-get update && \ | ||
| apt-get install -y ca-certificates && \ | ||
| dpkg -i /openvox${OPENVOX_RELEASE}-release-ubuntu${UBUNTU_VERSION}.deb && \ |
There was a problem hiding this comment.
Apt can install local files just fine
There was a problem hiding this comment.
oh okay didnt know... will try that. is it like in yum?
There was a problem hiding this comment.
Kind of, I'd say yum does it a little better because you can also point it to http(s) URLs. With apt you need to get it somehow (like wget) and the use apt install /path/to/file.deb. You can't use a relative path so you must use ./file.deb if it's in the current directory.
|
And I missed that you already merged it when I was reviewing. |
|
sry, auto merge was on... |
3 participants
No description provided.